Consolidate label-processing code #24

New issue

Open

opened 2013-09-09 22:42:16 +00:00 by kanzure · 0 comments

kanzure commented

2013-09-09 22:42:16 +00:00

(Migrated from github.com)

The label processing code in extras/ is getting ridiculous. There are a few separate locations where label processing code is implemented:

class Label in crystal.py
miscellaneous functions in crystal.py
various unit tests in crystal.py
labels.py
class RomStr in romstr.py

These should be consolidated and merged into one location. I bet there might even be one or two functions that are conceptually similar.

Above issue is from https://github.com/kanzure/pokecrystal/issues/37

The label processing code in `extras/` is getting ridiculous. There are a few separate locations where label processing code is implemented: - `class Label` in `crystal.py` - miscellaneous functions in `crystal.py` - various unit tests in `crystal.py` - `labels.py` - `class RomStr` in `romstr.py` These should be consolidated and merged into one location. I bet there might even be one or two functions that are conceptually similar. --- Above issue is from https://github.com/kanzure/pokecrystal/issues/37

This discussion has been locked. Commenting is limited to contributors.