lz compression bug. Reverse command is broken. #84

Open
opened 2014-10-13 04:16:11 +00:00 by Pigu-A · 2 comments
Pigu-A commented 2014-10-13 04:16:11 +00:00 (Migrated from github.com)

When I was making my own crystal hack, I noticed that the logo have a problem.

This logo is a compressed graphics, so I decided to dump this file to see what command that caused this problem and found out that all of the problem pixels are the part of reverse (0x6) command.

I tried to make the compression routine in gfx.py to not to score and do the reverse command then compress it. No problems found.

I concluded that there was a problem in reverse compression routine in gfx.py

When I was making my own crystal hack, I noticed that the logo have a problem. ![](http://i.imgur.com/QDmfolc.png) This logo is a compressed graphics, so I decided to dump this file to see what command that caused this problem and found out that all of the problem pixels are the part of reverse (0x6) command. I tried to make the compression routine in gfx.py to not to score and do the reverse command then compress it. No problems found. ![](http://i.imgur.com/BiD3FjU.png) I concluded that there was a problem in reverse compression routine in gfx.py
kanzure commented 2014-10-13 04:26:55 +00:00 (Migrated from github.com)

Have you tested your modified gfx.py against compiling pokered or pokecrystal?

Have you tested your modified gfx.py against compiling pokered or pokecrystal?
yenatch commented 2014-12-12 22:32:06 +00:00 (Migrated from github.com)

Fixed in #86.

Fixed in #86.
This discussion has been locked. Commenting is limited to contributors.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
decomp/pokemon-reverse-engineering-tools#84
No description provided.