heni/discord-irc
heni/discord-irc
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 25 Packages Wiki Activity Actions

Enable compilerOptions.experimentalDecorators for compatibility with Deno 1.41 #60

Merged
catuhana merged 1 commit from deno-v1.41 into main 2024-02-26 21:20:06 +00:00
Conversation 5 Commits 1 Files changed 1 +3
catuhana commented 2024-02-23 10:11:02 +00:00 (Migrated from github.com)
Copy link

Deno 1.41 have an entirely different Decorator API, and libraries we use (mainly Harmony) is not ported to it. To get benefits of smaller deno compile and native ARM64 Linux outputs, we allow old Decorator API for now.

Deno 1.41 have an entirely different Decorator API, and libraries we use (mainly Harmony) is not ported to it. To get benefits of smaller `deno compile` and native ARM64 Linux outputs, we allow old Decorator API for now.
MTF (Migrated from github.com) reviewed 2024-02-23 10:11:02 +00:00
catuhana commented 2024-02-23 10:16:57 +00:00 (Migrated from github.com)
Copy link

To add a note: aarch64-unknown-linux-gnu target is still not added to deno compile --target flag.

To add a note: `aarch64-unknown-linux-gnu` target is still not added to `deno compile --target` flag.
catuhana commented 2024-02-23 11:13:52 +00:00 (Migrated from github.com)
Copy link

I cloned Deno locally and added aarch64 Linux target to see if it was uncomplete or just aren't added to compile flags, and it seems the latter. We just need to wait for Deno to add those targets. After that we can drop pi runner.

Also there seems to be a bug with compile, it won't save the output file with os error 13. I'm hoping those will be fixed with Deno 1.41.1. Doesn't happen with CI or Docker, might be related to my system.

I cloned Deno locally and added `aarch64` Linux target to see if it was uncomplete or just aren't added to `compile` flags, and it seems the latter. We just need to wait for Deno to add those targets. After that we can drop `pi` runner. ~~Also there seems to be a bug with `compile`, it won't save the output file with `os error 13`. I'm hoping those will be fixed with Deno 1.41.1.~~ Doesn't happen with CI or Docker, might be related to my system.
catuhana commented 2024-02-23 13:37:19 +00:00 (Migrated from github.com)
Copy link

Apparently, denoland/deno#22542 exists.

Apparently, denoland/deno#22542 exists.
aronson (Migrated from github.com) approved these changes 2024-02-26 21:19:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
MTF
aronson
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
heni/discord-irc!60
No description provided.