No Wram Execution Command Line Argument

anmart commented

2016-06-04 04:30:51 +00:00

(Migrated from github.com)

This is more of a suggestion with code to back it up than a commit. I tried using tcgdisasm.py and got a couple jumps to wram labels that I didn't want. Rather than fixing them manually, I thought it would be nice to have an argument that could force the disassembler to skip wram labels when considering calls or jumps.

I know very little about python and even less about the poketools, but I thought I'd give writing the modifications a shot. I'd just like for wram execution avoidance to be an option eventually.

edit: I realized this wasn't as clear as it could have been. In tcgdisasm.py (and I believe only this script), pointers in bank 3 were being replaced with wram labels because the disassembler assumed that they were addresses in bank 3. -nwe just enables the script to assume labels starting with "w" are not local labels.

This is more of a suggestion with code to back it up than a commit. I tried using tcgdisasm.py and got a couple jumps to wram labels that I didn't want. Rather than fixing them manually, I thought it would be nice to have an argument that could force the disassembler to skip wram labels when considering calls or jumps. I know very little about python and even less about the poketools, but I thought I'd give writing the modifications a shot. I'd just like for wram execution avoidance to be an option eventually. edit: I realized this wasn't as clear as it could have been. In tcgdisasm.py (and I believe only this script), pointers in bank 3 were being replaced with wram labels because the disassembler assumed that they were addresses in bank 3. -nwe just enables the script to assume labels starting with "w" are not local labels.

dannye commented

2016-06-04 16:20:11 +00:00

(Migrated from github.com)

To be fair, tcgdisasm.py is a shitty edit of gbz80disasm.py that allows it to handle the farcall macro.
But gbz80disasm.py just got completely remade the other day, so now tcgdisasm.py and gbz80disasm.py are nothing alike. This should probably be remade too.

To be fair, tcgdisasm.py is a shitty edit of gbz80disasm.py that allows it to handle the farcall macro. But gbz80disasm.py just got completely remade the other day, so now tcgdisasm.py and gbz80disasm.py are nothing alike. This should probably be remade too.

This pull request is broken due to missing fork information.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin unknown repository:unknown repository

git switch unknown repository

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master

git merge --no-ff unknown repository

git switch unknown repository

git rebase master

git switch master

git merge --ff-only unknown repository

git switch unknown repository

git rebase master

git switch master

git merge --no-ff unknown repository

git switch master

git merge --squash unknown repository

git switch master

git merge --ff-only unknown repository

git switch master

git merge unknown repository

git push origin master

Rows
Columns

No Wram Execution Command Line Argument #101

Checkout

Merge