heni/discord-irc
heni/discord-irc
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 25 Packages Wiki Activity Actions

Auto-create and reuse bot-owned webhooks #59

Merged
aronson merged 6 commits from webhooks into main 2023-12-11 03:53:06 +00:00
Conversation 4 Commits 6 Files changed 9 +58 -21
aronson commented 2023-12-10 09:58:28 +00:00 (Migrated from github.com)
Copy link

The bot can create its own webhooks. I wrote this a while ago.

Idea:

  • Bot creates its own webhooks when reading channel list in channelMapping.ts
  • Bot searches for existing webhooks by channel and webhook name
  • config.json now only cares if webhook field defined whatsoever to enable (matches original behavior)
  • Mixed states of some webhook and some non-webhook no longer supported (could add back later)
The bot can create its own webhooks. I wrote this a while ago. Idea: - Bot creates its own webhooks when reading channel list in channelMapping.ts - Bot searches for existing webhooks by channel and webhook name - config.json now only cares if webhook field defined whatsoever to enable (matches original behavior) - Mixed states of some webhook and some non-webhook no longer supported (could add back later)
MTF (Migrated from github.com) reviewed 2023-12-10 20:01:54 +00:00
lib/config.ts
@ -49,7 +49,7 @@ export type Config = {
parallelPingFix?: boolean;
MTF (Migrated from github.com) commented 2023-12-10 20:01:54 +00:00
Copy link

Unknown? Shouldn't this be a boolean

Unknown? Shouldn't this be a boolean
aronson (Migrated from github.com) reviewed 2023-12-10 20:03:03 +00:00
lib/config.ts
@ -49,7 +49,7 @@ export type Config = {
parallelPingFix?: boolean;
aronson (Migrated from github.com) commented 2023-12-10 20:03:03 +00:00
Copy link

No actually, this is a clever trick to support users with the old record config transparently.

No actually, this is a clever trick to support users with the old record config transparently.
aronson (Migrated from github.com) reviewed 2023-12-10 20:12:44 +00:00
lib/config.ts
@ -49,7 +49,7 @@ export type Config = {
parallelPingFix?: boolean;
aronson (Migrated from github.com) commented 2023-12-10 20:12:44 +00:00
Copy link

As we discussed, this will become a Boolean

As we discussed, this will become a Boolean
MTF (Migrated from github.com) approved these changes 2023-12-11 03:46:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
MTF
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
heni/discord-irc!59
No description provided.